[v10] Machine ID support for Logins trait (#15117) #15470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Support user traits in impersonated role certificates * Add param to tctl bots add for specifying logins * Update comment on desiredAccessInfoForRoleRequest to be mroe accurate * Update docs for --logins support with Machine ID * Rearrange bot tests and name them more in-line with standards * Add test coverage for Server.createBot * Test role impersonation preserves user traits * pass traits directly into desiredAccessInfoForRoleRequests * Drop underscores from test names * Remove unnecessary initialization of traits * Address PR comments * Update docs/pages/machine-id/getting-started.mdx Co-authored-by: Paul Gottschling <paul.gottschling@goteleport.com> * Update docs/pages/machine-id/getting-started.mdx Co-authored-by: Paul Gottschling <paul.gottschling@goteleport.com> * Update docs/pages/machine-id/getting-started.mdx Co-authored-by: Paul Gottschling <paul.gottschling@goteleport.com> Co-authored-by: Paul Gottschling <paul.gottschling@goteleport.com>
strideynet
changed the title
github-actions
bot
requested review from
jakule,
ptgott,
r0mant,
timothyb89 and
zmb3
ptgott
approved these changes
Aug 12, 2022
timothyb89
approved these changes
Aug 12, 2022
tigrato
approved these changes
Aug 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #15117