Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v9] Fix infinite session heartbeat failures #16097

Merged
merged 2 commits into from Sep 2, 2022
Merged

[v9] Fix infinite session heartbeat failures #16097

merged 2 commits into from Sep 2, 2022

Commits on Sep 2, 2022

  1. Fix infinite session heartbeat failures 

    The session heartbeat loop wasn't checking if the context was
done, which resulted in an infinite loop of UpdateSession calls
that would never succeed and constantly trip the circuit breaker.

The context will only be cancelled if the session is terminated, so
we can simply return when either the context is done or the stop
channel was closed, whichever comes first.

Fixes #15695
    @rosstimothy
    rosstimothy authored and github-actions committed Sep 2, 2022
    Copy the full SHA
    922debc View commit details
    Browse the repository at this point in the history

  2. abort session heartbeat if session doesn't exist

    @rosstimothy
    rosstimothy authored and github-actions committed Sep 2, 2022
    Copy the full SHA
    f9f80b7 View commit details
    Browse the repository at this point in the history