Dial by UUID for label based ssh #16257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fspmarshall
approved these changes
Sep 8, 2022
ryanclark
approved these changes
Sep 8, 2022
|
Looks like |
Switches label based ssh to always use the node UUID instead of its address. This prevents issues that occurred when dialing by address if the public_addr isn't set correctly. Closes #3214
rosstimothy
force-pushed
the
tross/dial_matches_by_id
branch
from
25c3909
to
f7fea63
Compare
|
@rosstimothy See the table below for backport results.
|
capnspacehook
pushed a commit
that referenced
this pull request
Sep 12, 2022
Switches label based ssh to always use the node UUID instead of its address. This prevents issues that occurred when dialing by address if the public_addr isn't set correctly. Closes #3214
rosstimothy
added a commit
that referenced
this pull request
Sep 12, 2022
Switches label based ssh to always use the node UUID instead of its address. This prevents issues that occurred when dialing by address if the public_addr isn't set correctly. Closes #3214
rosstimothy
added a commit
that referenced
this pull request
Sep 12, 2022
Switches label based ssh to always use the node UUID instead of its address. This prevents issues that occurred when dialing by address if the public_addr isn't set correctly. Closes #3214
rosstimothy
added a commit
that referenced
this pull request
Sep 13, 2022
rosstimothy
added a commit
that referenced
this pull request
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches label based ssh to always use the node UUID instead of its address. This prevents issues that occurred when dialing by address if the
public_addrisn't set correctly.Closes #3214