Correct the UACC wtmp path #17416
Merged
Correct the UACC wtmp path #17416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
camscale
approved these changes
Oct 17, 2022
jakule
force-pushed
the
jakule/fix-wtmp-path
branch
from
709750c
to
7ebc945
Compare
mdwn
approved these changes
Oct 20, 2022
Move paths declaration to Go
jakule
force-pushed
the
jakule/fix-wtmp-path
branch
from
7ebc945
to
a669ff7
Compare
jakule
added a commit
that referenced
this pull request
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Teleport assumes that
wtmpfiles are always stored in/var/run/wtmpwhich is not true for all distributions. This patch checks for the old path and/var/run/wtmpwhere Ubuntu, Centos, etc store the file. I also moved some code from the C to Go, as it's easier for us to maintain.