SIGINT handling #1845
Merged
SIGINT handling #1845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klizhentas
reviewed
Apr 4, 2018
|
|
||
| select { | ||
| // ConnectToProxy returned a result, return that back to the caller. | ||
| case <-connectContext.Done(): |
There was a problem hiding this comment.
I remember I left a comment earlier today about merging parent context and this one, but disregard it, your code is actually correct and my suggestion will not work.
klizhentas
approved these changes
Apr 4, 2018
running an "exec" request without a TTY.
russjones
force-pushed
the
rjones/sigint-handling
branch
from
8ba921f
to
3c80ce1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#1650 raised two issues with SIGINT handling of
tsh. The first is that Ctrl-C does not work when network connectivity is down. The second is that Ctrl-C does not work when running a command against multiple nodes (like tailing log files).Implementation
ConnectToProxywhere it should try to connect to the proxy in another goroutine and exit early if the context has been canceled.Related Issues
Fixes #1650