Fetch and buffer all entries from LDAP search #19002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strideynet
approved these changes
Dec 2, 2022
zmb3
reviewed
Dec 2, 2022
LKozlowski
force-pushed
the
lkozlowski/17797-ldap-size-limit-exceeded
branch
from
3aebd1a
to
13af8ac
Compare
LKozlowski
force-pushed
the
lkozlowski/17797-ldap-size-limit-exceeded
branch
from
13af8ac
to
82ea6b4
Compare
zmb3
approved these changes
Dec 5, 2022
LKozlowski
force-pushed
the
lkozlowski/17797-ldap-size-limit-exceeded
branch
3 times, most recently
from
476ea01
to
7c65b43
Compare
LKozlowski
force-pushed
the
lkozlowski/17797-ldap-size-limit-exceeded
branch
from
7c65b43
to
8fde7a5
Compare
|
@LKozlowski this should be backported to all supported versions (9, 10, and 11) |
Are we going to also backport #18021 to all versions? If so then I'll wait for it as this PR changed a lot of the code & file structure so my changes can't be easily applied by cherry-picking. If not, I'll just backport it manually as my change wasn't that big anyway. Just don't want to make a mess if we're going to backport it. |
This was referenced Dec 20, 2022
LKozlowski
pushed a commit
that referenced
this pull request
Dec 21, 2022
LKozlowski
pushed a commit
that referenced
this pull request
Dec 21, 2022
LKozlowski
pushed a commit
that referenced
this pull request
Dec 21, 2022
LKozlowski
pushed a commit
that referenced
this pull request
Dec 21, 2022
LKozlowski
pushed a commit
that referenced
this pull request
Dec 21, 2022
LKozlowski
pushed a commit
that referenced
this pull request
Dec 21, 2022
LKozlowski
pushed a commit
that referenced
this pull request
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17797.
Before it would throw an
Size Limit Exceedederror when there were more search results than the search size limit.Now, it will make as many calls as needed to fetch all the results without throwing an error.
In some cases, if there is a lot of entries, the search might slow down a bit as there will be more requests made to fetch all entries.