[v10] Ensure tctl windows_desktops ls produces expected output
#19015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit ensures that `tctl desktops ls --format json|yaml` outputs a
list of `windows_desktop` resources. Note that `tctl desktops ls`
displays additional information that is only present in the
`windows_desktop_service`.
With `tctl windows_desktops ls --format json` now we get something like the
following:
```json
[
{
"kind": "windows_desktop",
"version": "v3",
"metadata": {
...
},
"spec": {
...
}
},
...
]
```
`tctl windows_desktops ls --format text` now also displays the same information
as `tctl get windows_desktop --format text` (removing all the info about the
`windows_desktop_service`):
```bash
❯ tctl get windows_desktop --format text
Name Address AD Domain Labels
--------------------------- ----------------- ----------- ------
EC2AMAZ-QME01PL-example-com 172.31.4.209:3389 example.com
❯ tctl windows_desktops ls
Name Address AD Domain Labels
--------------------------- ----------------- ----------- ------
EC2AMAZ-QME01PL-example-com 172.31.4.209:3389 example.com
```
zmb3
approved these changes
Dec 2, 2022
nklaassen
approved these changes
Dec 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #18779 to branch/v10