[v10] Move SAML connection validation after auth checks #19318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the validation for SAML connectors being inserted or updated (Upsert) from before the role check for Insert/Update to after it. The validation can perform an HTTP GET request if the `entity_descriptor_url` field is set. This should at least require that the user have permission to Upsert a SAML OIDC connector. Ensure that roles exist that are referenced in SAML connectors, as the roles in SAML connectors are validated as the connector is inserted or updated. The validation has moved to auth.Server (from grpcserver) so that is now required in tests that operate against auth.Server. Add a test case to test that an access denied error is returned when upserting an invalid SAML connector instead of a validation failure, showing that we are not using input from untrusted sources. Also test that validation is still performed when access is permitted and that a valid SAML connector can be upserted. Backport: #17531
codingllama
approved these changes
Dec 13, 2022
zmb3
approved these changes
Dec 13, 2022
fheinecke
pushed a commit
that referenced
this pull request
Dec 16, 2022
Move the validation for SAML connectors being inserted or updated (Upsert) from before the role check for Insert/Update to after it. The validation can perform an HTTP GET request if the `entity_descriptor_url` field is set. This should at least require that the user have permission to Upsert a SAML OIDC connector. Ensure that roles exist that are referenced in SAML connectors, as the roles in SAML connectors are validated as the connector is inserted or updated. The validation has moved to auth.Server (from grpcserver) so that is now required in tests that operate against auth.Server. Add a test case to test that an access denied error is returned when upserting an invalid SAML connector instead of a validation failure, showing that we are not using input from untrusted sources. Also test that validation is still performed when access is permitted and that a valid SAML connector can be upserted. Backport: #17531
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the validation for SAML connectors being inserted or updated (Upsert)
from before the role check for Insert/Update to after it. The validation
can perform an HTTP GET request if the
entity_descriptor_urlfield isset. This should at least require that the user have permission to
Upsert a SAML OIDC connector.
Ensure that roles exist that are referenced in SAML connectors, as the
roles in SAML connectors are validated as the connector is inserted or
updated. The validation has moved to auth.Server (from grpcserver) so
that is now required in tests that operate against auth.Server.
Add a test case to test that an access denied error is returned when
upserting an invalid SAML connector instead of a validation failure,
showing that we are not using input from untrusted sources. Also test
that validation is still performed when access is permitted and that a
valid SAML connector can be upserted.
Backport: #17531
NOTE: This should have been backported a little while ago, but I forgot.