[v9] Allow custom trace exporter for tsh #19588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosstimothy
changed the title
rosstimothy
force-pushed
the
tross/backport-19405/v9
branch
from
8174377
to
95149ad
Compare
github-actions
bot
added
size/md
tsh
rosstimothy
force-pushed
the
tross/backport-19405/v9
branch
from
95149ad
to
523aac3
Compare
smallinsky
approved these changes
Dec 22, 2022
jakule
requested changes
Dec 22, 2022
Trace forwarding via `tsh --trace` only works to date if Auth is configured with the `tracing_service` enabled. In all other scenarios the traces are still forwarded to Auth but are silently dropped. This makes it difficult to capture valuable traces from customers with latency issues as they are first required to setup a Telemetry backend and enable tracing in their cluster. A new `--trace-exporter` flag is added to `tsh` to make it possible to direct traces from `tsh` to a file or local instance of jaeger without hacing to modify their Teleport cluster. The url must follow the same semantics as the config file equivalent. One important caveat is that **only** the `tsh` spans will be captured. Any corresponding `teleport` spans are exported acording to the `tracing_service`. While this only paints half the picture, it is still a good indicator of where `tsh` may be experiencing latency. An example usage to send traces to local files: ```bash tsh --trace --trace-exporter=file:///some/path/traces ssh user@foo ```
rosstimothy
force-pushed
the
tross/backport-19405/v9
branch
from
88c3495
to
ee86240
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #19405 to branch/v9