[v9] Fix RBAC rules for desktop session recordings #19711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmb3
commented
Dec 28, 2022
| @@ -69,6 +69,7 @@ ssh.config | |||
|
|
|||
| # build tooling | |||
| build.assets/tooling/bin/** | |||
| build.assets/.cache/ | |||
There was a problem hiding this comment.
This was an intentional change that's on other branches but never made it to v9 and makes switching branches a pain.
Technically not related to this PR, but so minor I'd rather include it than have to wait for another set of v9 tests to pass to merge it in.
atburke
approved these changes
Dec 28, 2022
espadolini
approved these changes
Dec 29, 2022
zmb3
force-pushed
the
zmb3/v9-backport-19629
branch
from
c42ee88
to
6a8f02c
Compare
Desktop session playback is currently the only playback that leverages the StreamSessionEvents API (though that will change with RFD 91). For this API, we were checking for VerbList instead of VerbRead. (The SSH session APIs were correctly checking VerbRead). Since all uses of actionForKindSession now use the same verb, I've removed the verb as an argument to prevent this mistake from happening again.
zmb3
force-pushed
the
zmb3/v9-backport-19629
branch
from
6a8f02c
to
74f0ff7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Desktop session playback is currently the only playback that leverages the StreamSessionEvents API (though that will change with RFD 91).
For this API, we were checking for VerbList instead of VerbRead. (The SSH session APIs were correctly checking VerbRead).
Since all uses of actionForKindSession now use the same verb, I've removed the verb as an argument to prevent this mistake from happening again.
Backports #19629