Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide flag to only display tsh binary version #20521

Merged
merged 20 commits into from
Feb 22, 2023

Conversation

stevenGravy
Copy link
Contributor

@stevenGravy stevenGravy commented Jan 21, 2023

Implements #17817

Before

$ tsh version
Failed to fetch proxy version: no profile provided and no current profile
Teleport v13.0.0-dev git: go1.19.5

Now can do

$ tsh version --client
Teleport v13.0.0-dev git: go1.19.5

@stevenGravy stevenGravy enabled auto-merge (squash) January 21, 2023 15:54
@github-actions github-actions bot added documentation size/sm tsh tsh - Teleport's command line tool for logging into nodes running Teleport. labels Jan 21, 2023
@stevenGravy stevenGravy linked an issue Jan 21, 2023 that may be closed by this pull request
@rosstimothy
Copy link
Contributor

Alternatively, we could drop the new flag and only report the proxy version if able to connect to it.

@stevenGravy
Copy link
Contributor Author

Alternatively, we could drop the new flag and only report the proxy version if able to connect to it.

But then you'd still get an error if the proxy is unreachable.

@stevenGravy
Copy link
Contributor Author

stevenGravy commented Jan 22, 2023

Alternatively, we could drop the new flag and only report the proxy version if able to connect to it.

But then you'd still get an error if the proxy is unreachable.

That's what this gh issue ask was. #17817

docs/pages/reference/cli.mdx Outdated Show resolved Hide resolved
docs/pages/reference/cli.mdx Outdated Show resolved Hide resolved
tool/tsh/tsh.go Outdated Show resolved Hide resolved
tool/tsh/tsh.go Outdated Show resolved Hide resolved
tool/tsh/tsh.go Outdated Show resolved Hide resolved
stevenGravy and others added 3 commits January 22, 2023 16:04
@rosstimothy
Copy link
Contributor

Alternatively, we could drop the new flag and only report the proxy version if able to connect to it.

But then you'd still get an error if the proxy is unreachable.

I was suggesting that we could treat errors connecting to the proxy or retrieving the version indicate that tsh version should omit the proxy version from the output instead of causing the command to exit with an error. If we did that then the new flag wouldn't be necessary.

@alexfornuto alexfornuto removed their assignment Feb 15, 2023
alexfornuto
alexfornuto previously approved these changes Feb 22, 2023
@stevenGravy stevenGravy added this pull request to the merge queue Feb 22, 2023
@alexfornuto alexfornuto removed this pull request from the merge queue due to a manual request Feb 22, 2023
@alexfornuto
Copy link
Contributor

Realizing that this is a new feature and the documentation for it, we should probably separate the docs into a different PR that can be backported separately after the feature is released into each major version.

@alexfornuto alexfornuto self-requested a review February 22, 2023 21:40
@alexfornuto alexfornuto dismissed their stale review February 22, 2023 21:45

Docs adjustments should be separated so that they don't go live before the feature changes are released.

@stevenGravy
Copy link
Contributor Author

Realizing that this is a new feature and the documentation for it, we should probably separate the docs into a different PR that can be backported separately after the feature is released into each major version.

They have been removed and will be put in a sep PR

@stevenGravy stevenGravy added this pull request to the merge queue Feb 22, 2023
Merged via the queue into master with commit 0fce40d Feb 22, 2023
@public-teleport-github-review-bot

@stevenGravy See the table below for backport results.

Branch Result
branch/v10 Failed
branch/v11 Failed
branch/v12 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation size/sm tsh tsh - Teleport's command line tool for logging into nodes running Teleport.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add client-only version option to tsh
4 participants