[v11] Ensure UpdateRemoteCluster updates all fields #22089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ConnectionStatus of the RemoteCluster resource was never being set in UpdateRemoteCluster causing the backend to always contain the original value. GetRemoteCluster, unfortunately, does an update of the resource, yet it always returned the correct information, which made things very confusing since `tctl get` didn't reflect the actual backend. To make matters worse the initial value was not explicitly set which meant it defaulted to an empty string. A call to SetConnectionStatus was added to UpdateRemoteCluster so it's value is actually persisted. Trusted Clusters are also now explicitly initialized with status offline to avoid ambiguity. The actual status of the resource will be updated appropriately when the tunnel connections are verified. Additionally TestRemoteClustersCRUD was added to capture this issue and prevent any regressions. Fixes #22006
zmb3
approved these changes
Feb 21, 2023
tigrato
approved these changes
Feb 21, 2023
public-teleport-github-review-bot
bot
removed the request for review
from fspmarshall
mdwn
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #22024 to branch/v11