[v10] Fix incorrect login options for Windows Desktops (#22118) #22344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcbattirola
approved these changes
Feb 27, 2023
zmb3
approved these changes
Feb 27, 2023
public-teleport-github-review-bot
bot
removed the request for review
from ryanclark
ibeckermayer
force-pushed
the
isaiah/backport-22118-branch/v10
branch
2 times, most recently
from
e62bc8a
to
4857822
Compare
ibeckermayer
force-pushed
the
isaiah/backport-22118-branch/v10
branch
from
4857822
to
3239d6b
Compare
auto-merge was automatically disabled
February 28, 2023 20:15
Merge queue setting changed
auto-merge was automatically disabled
March 1, 2023 17:00
Merge queue setting changed
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
ibeckermayer
added a commit
that referenced
this pull request
Apr 10, 2023
Changes in #22118 were backported incorrectly to v10 in #22344, which caused the roles list/read dependency to be enforced for listing desktops. These changes fix that issue by using the SessionContext's AccessChecker to get the Roles of the current user, rather than requesting them with the auth.ClientI which is authenticated as the user themselves.
ibeckermayer
added a commit
that referenced
this pull request
Apr 10, 2023
Changes in #22118 were backported incorrectly to v10 in #22344, which caused the roles list/read dependency to be enforced for listing desktops. These changes fix that issue by using the SessionContext's AccessChecker to get the Roles of the current user, rather than requesting them with the auth.ClientI which is authenticated as the user themselves.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backports #22118 to branch/v10
relates to https://github.com/gravitational/teleport.e/pull/919