[v10] sshserver: Correctly handle PuTTY winadj channel requests #22421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* sshserver: Correctly handle PuTTY winadj channel requests Fixes #19365 * Actually send a failure * dispatch changes * Reimplement wantReply handling * Also handle windadj in forwarding server * lint: Fix typo * lint: Invert return order to put err last * Use nil return payload instead * Use trace.ReplyAlreadyHandled instead * Handle reply internally and set req.WantReply to false * Use t.Cleanup() * behaviour is not a misspelling but whatever makes you happy * Suggestions from code review
webvictim
changed the title
rosstimothy
approved these changes
Feb 28, 2023
jakule
approved these changes
Feb 28, 2023
public-teleport-github-review-bot
bot
removed request for
klizhentas and
zmb3
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #19468 to branch/v10