Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v10] Refresh remote cluster connection status periodically #22573

Merged
merged 1 commit into from Mar 3, 2023

Conversation

andreiko
Copy link
Contributor

@andreiko andreiko commented Mar 2, 2023

Backport #22455 to branch/v10

Copy link
Contributor

@codingllama codingllama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's no api/utils/retryutils in v10, you may have to backport that too.

For reference:

(Edit: sent too quickly.)

@rosstimothy
Copy link
Contributor

rosstimothy commented Mar 3, 2023

Looks like there's no api/utils/retryutils in v10, you may have to backport that too.

For reference:

(Edit: sent too quickly.)

Should just be able to use utils/retry.go

@codingllama
Copy link
Contributor

I suggest backporting all the relevant PRs, so we don't end up in some in-between state here.

@rosstimothy
Copy link
Contributor

I suggest backporting all the relevant PRs, so we don't end up in some in-between state here.

The rest of v10 is using utils.NewSeventhJitter so I don't see the problem in doing so here too. If we do pull just the retryutils changes from the relevant PRs into v10 I think a separate PR would probably be best.

@andreiko
Copy link
Contributor Author

andreiko commented Mar 3, 2023

Pushed an update to use utils.NewSeventhJitter 43b7dc6

It's already used a couple times in the same runPeriodicOperations() function so it seems acceptable:
https://github.com/gravitational/teleport/blob/43b7dc6deb3a433c4ef863b844b0636003b6badf/lib/auth/auth.go#L459-L466

@andreiko andreiko force-pushed the bot/backport-22455-branch/v10 branch from 43b7dc6 to e140833 Compare March 3, 2023 20:22
@andreiko andreiko enabled auto-merge March 3, 2023 20:23
@andreiko andreiko added this pull request to the merge queue Mar 3, 2023
Merged via the queue into branch/v10 with commit 4f5fea2 Mar 3, 2023
@github-actions github-actions bot deleted the bot/backport-22455-branch/v10 branch March 3, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants