Validate static labels assigned to Kubernetes service #22701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobiaszheller
approved these changes
Mar 7, 2023
zmb3
reviewed
Mar 7, 2023
This PR introduces the static label's key validation to Kubernetes Service. Services with invalid labels fail to hearbeat their clusters but the service is kept working. This change forces the service to fail fast during startup if any key is invalid. Fixes #22696
tigrato
force-pushed
the
tigrato/validate-invalid-keys
branch
from
f2affd7
to
eadbe9b
Compare
zmb3
approved these changes
Mar 7, 2023
public-teleport-github-review-bot
bot
removed the request for review
from jakule
tigrato
added a commit
that referenced
this pull request
Mar 8, 2023
This PR introduces the static label's key validation to Kubernetes Service. Services with invalid labels fail to hearbeat their clusters but the service is kept working. This change forces the service to fail fast during startup if any key is invalid. Fixes #22696
tigrato
added a commit
that referenced
this pull request
Mar 8, 2023
This PR introduces the static label's key validation to Kubernetes Service. Services with invalid labels fail to hearbeat their clusters but the service is kept working. This change forces the service to fail fast during startup if any key is invalid. Fixes #22696
tigrato
added a commit
that referenced
this pull request
Mar 8, 2023
This PR introduces the static label's key validation to Kubernetes Service. Services with invalid labels fail to hearbeat their clusters but the service is kept working. This change forces the service to fail fast during startup if any key is invalid. Fixes #22696
tigrato
added a commit
that referenced
this pull request
Mar 9, 2023
This PR introduces the static label's key validation to Kubernetes Service. Services with invalid labels fail to hearbeat their clusters but the service is kept working. This change forces the service to fail fast during startup if any key is invalid. Fixes #22696
tigrato
added a commit
that referenced
this pull request
Mar 9, 2023
This PR introduces the static label's key validation to Kubernetes Service. Services with invalid labels fail to hearbeat their clusters but the service is kept working. This change forces the service to fail fast during startup if any key is invalid. Fixes #22696
tigrato
added a commit
that referenced
this pull request
Mar 9, 2023
This PR introduces the static label's key validation to Kubernetes Service. Services with invalid labels fail to hearbeat their clusters but the service is kept working. This change forces the service to fail fast during startup if any key is invalid. Fixes #22696
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the static label's key validation to Kubernetes Service. Services with invalid labels failed to heartbeat their clusters, but the service kept working. This change forces the service to fail fast during startup if any key is invalid.
Fixes #22696