Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connect: Show config file errors #22728

Merged
merged 16 commits into from
Mar 13, 2023
Merged

Connect: Show config file errors #22728

merged 16 commits into from
Mar 13, 2023

Commits on Mar 7, 2023

  1. Add a function that returns error that might happen during loading th… 

    …e file
    @gzdunek
    gzdunek committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    56f0fee View commit details
    Browse the repository at this point in the history

  2. Return validation and file loading errors from ConfigService

    @gzdunek
    gzdunek committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    c4b1723 View commit details
    Browse the repository at this point in the history

  3. Discard file storage updates when the file was not loaded correctly

    @gzdunek
    gzdunek committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    cf8b8ee View commit details
    Browse the repository at this point in the history

  4. Do not show usage reporting dialog when the file was not loaded corre… 

    …ctly
    @gzdunek
    gzdunek committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    14a9ecb View commit details
    Browse the repository at this point in the history

  5. Make title of notifications a little bit smaller, so longer titles do… 

    … not look weird
    @gzdunek
    gzdunek committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    286efc5 View commit details
    Browse the repository at this point in the history

  6. Get rid of sync fs functions wherever possible in file storage

    @gzdunek
    gzdunek committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    3a44790 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2023

  1. Move error handling code to createFileStorage

    @gzdunek
    gzdunek committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    5fc9edd View commit details
    Browse the repository at this point in the history

  2. Improve getConfigError comment

    @gzdunek
    gzdunek committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    3aa0055 View commit details
    Browse the repository at this point in the history

  3. Rename discardUpdatesWhenLoadingFileFailed to `discardUpdatesOnLoad… 

    …Error`
    @gzdunek
    gzdunek committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    1218bbe View commit details
    Browse the repository at this point in the history

  4. Fix the error message in notifyAboutConfigErrors

    @gzdunek
    gzdunek committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    089babc View commit details
    Browse the repository at this point in the history

  5. Revert "Make title of notifications a little bit smaller, so longer t… 

    …itles do not look weird"
    @gzdunek
    gzdunek committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    87f6099 View commit details
    Browse the repository at this point in the history

  6. Make writeSync async too

    @gzdunek
    gzdunek committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    45c3aa3 View commit details
    Browse the repository at this point in the history

  7. Return unknown from FileStorage.get

    @gzdunek
    gzdunek committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    5fa78d4 View commit details
    Browse the repository at this point in the history

  8. Add a TODO comment about createFileStorage type

    @ravicious
    ravicious committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    d321f8d View commit details
    Browse the repository at this point in the history

  9. Add "the" to "Using default config instead"

    @gzdunek
    gzdunek committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    a9350f2 View commit details
    Browse the repository at this point in the history

  10. Remove toString()

    @gzdunek
    gzdunek committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    13a8a9d View commit details
    Browse the repository at this point in the history