[v10] Swap out select for poll (#22676) and Loop for poll (#22746) #22800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Swap out select for poll wait_for_fd now uses poll instead of select, allowing us to wait for file descriptors > 1024. * Restructuring the function to simplify and adds a log statement on error * Puts poll in a loop that checks for EINTR and EAGAIN and calls it again if either of those errors were the source of the error.
zmb3
approved these changes
Mar 8, 2023
tigrato
approved these changes
Mar 8, 2023
public-teleport-github-review-bot
bot
removed request for
espadolini and
timothyb89
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #22676 and #22746 to branch/v10