[v10] Add per-session mfa support to connection testers (#22528) #22922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add MFAAuthenticateResponse field to GenerateUserCerts * Pass MFA response for connection testers * Add checking MFA web endpoint * Address CRs
codingllama
approved these changes
Mar 10, 2023
lib/web/mfa.go
Outdated
| return protoReq, nil | ||
| } | ||
|
|
||
| type isMfaRequiredResponse struct { |
There was a problem hiding this comment.
Did we miss this one in the renames?
There was a problem hiding this comment.
OH NOOOO!!! i did... 😭 i'll fix them in the backports, for master i'll sneak it in
There was a problem hiding this comment.
No worries! Thanks for the fix.
zmb3
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #22528 to branch/v10