-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connect: Update Electron to 22.3.2 #23031
Conversation
Did you perform the tests after I updated node-pty or before that? |
Before 🫣 |
Could you make local Linux and macOS builds then to verify that the shell is still working correctly? I'm making one on Windows at the moment. |
Sure 🫡 |
Mac and Linux work fine 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to work fine on Windows.
Dev build: 12.1.0-dev.gzdunek.1
Tested on: macOS, Windows, Ubuntu, Fedora (for Linux I created local builds)
I didn't not find any issues.