Validate proxy peer identity #23392
Merged
Validate proxy peer identity #23392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosstimothy
force-pushed
the
tross/peer_id_validation
branch
2 times, most recently
from
c81a94c
to
2d05221
Compare
zmb3
reviewed
Mar 21, 2023
fspmarshall
approved these changes
Mar 22, 2023
GavinFrazar
approved these changes
Mar 22, 2023
zmb3
approved these changes
Mar 22, 2023
Closes #23230 Proxy peer clients now validate that any connections established to a peer have the expected UUID. This prevents clients from connecting to incorrect peers if the `peer_public_addr` is shared by multiple proxies, or is a load balancer. In the event that a connection is established to an incorrect peer the connection is closed and a error is written to the logs. The gRPC connection should be attempted multiple times and eventually land on the correct peer. However there may be some degradation of service until the peer connections are all properly established.
rosstimothy
force-pushed
the
tross/peer_id_validation
branch
from
180dbd5
to
1ea796f
Compare
This was referenced Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #23230
Proxy peer clients now validate that any connections established to a peer have the expected UUID. This prevents clients from connecting to incorrect peers if the
peer_public_addris shared by multiple proxies, or is a load balancer.In the event that a connection is established to an incorrect peer the connection is closed and a error is written to the logs. The gRPC connection should be attempted multiple times and eventually land on the correct peer. However there may be some degradation of service until the peer connections are all properly established.