Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aws/config): Support configuring auth_service.proxy_listener_mode #23576

Conversation

sklirg
Copy link
Contributor

@sklirg sklirg commented Mar 24, 2023

Fixes #23570

I tested this "manually" by removing the /etc/teleport.yaml configuration file and then re-running systemctl start teleport-generate-config after applying this patch to /usr/local/bin/teleport-generate-config.

@r0mant r0mant requested review from tcsc and hugoShaka and removed request for r0mant and jimbishopp March 24, 2023 17:53
Copy link
Contributor

@tcsc tcsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not an expert on this yet, but this patch seems to be doing what it says its doing. Thanks for the contribution.

@sklirg
Copy link
Contributor Author

sklirg commented Mar 27, 2023

Shout if you need me to do anything, from what I gather the "Checking reviewers"-check fails because it's missing reviews from some specific people, and this PR requires approval to run further checks. 👍

@r0mant
Copy link
Collaborator

r0mant commented Mar 27, 2023

@sklirg Thank you for your contribution. We'll merge your change in this "buddy" PR: #23669.

@r0mant r0mant closed this Mar 27, 2023
@sklirg sklirg deleted the fix/23570-configure-proxy-multiplex-on-auth_service branch March 28, 2023 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support configuring auth_service.proxy_listener_mode through teleport-generate-configuration
4 participants