[v11] Fix multiple profile handling for kube credentials #23718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes the multi profile handling for Kubernetes Access flow. Previously, `tsh kube credentials` assumed the default profile because no proxy was provided when kubectl invokes the credentials plugin which resulted in usage of wrong certificates. This PR prevents that by appending the `--proxy` flag to kubectl exec plugin which allows `tsh kube credentials` to correctly identify the correct profile.
github-actions
bot
added
backport
size/sm
tsh
atburke
approved these changes
Mar 28, 2023
espadolini
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #23705 to branch/v11