helm: Propagate securityContext and nodeSelector to Job hooks #24012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugoShaka
approved these changes
Apr 3, 2023
webvictim
changed the title
|
@hugoShaka PTAL, I added |
hugoShaka
approved these changes
Apr 5, 2023
zmb3
approved these changes
Apr 5, 2023
public-teleport-github-review-bot
bot
removed the request for review
from klizhentas
|
@webvictim See the table below for backport results.
|
webvictim
added a commit
that referenced
this pull request
Apr 5, 2023
* helm: Propagate securityContext to Job hooks * Also support nodeSelector
webvictim
added a commit
that referenced
this pull request
Apr 5, 2023
#24134) * helm: Propagate securityContext to Job hooks * Also support nodeSelector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We didn't propagate the
securityContextconfigured in the values to either of theJobs that we create, leading to issues with the job failing to run in clusters which enforce PSPs.We also didn't pass
nodeSelectorwhen configured in the values either, leading to unpredictable workload scheduling.I couldn't find a clean way to add a unit test for the changes to
hook.yamlas that job is only optionally created when aDeploymentalready exists on upgrade.