Only call 'user.Current' when we really need to #24156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size/sm
tsh
r0mant
reviewed
Apr 5, 2023
There was a problem hiding this comment.
@capnspacehook Before we merge this, let's cut a dev release with this change and share it with the customer. Drone is having some issues atm though, I'll let you know when it's ready. For now I'll add do-not-merge label.
russjones
reviewed
Apr 5, 2023
There was a problem hiding this comment.
@capnspacehook Can we provide an actionable error message if user.Current() is slow for users here as well?
This is a good workaround, but it's not clear that the user will ever know if/when to use this workaround.
|
@russjones replaced all |
russjones
reviewed
Apr 6, 2023
r0mant
reviewed
Apr 7, 2023
capnspacehook
force-pushed
the
capnspacehook/avoid-user-current
branch
from
fe31c6b
to
891dec9
Compare
russjones
approved these changes
Apr 11, 2023
mdwn
approved these changes
Apr 11, 2023
capnspacehook
force-pushed
the
capnspacehook/avoid-user-current
branch
from
891dec9
to
9d9580d
Compare
Calling 'user.Current' can be extremely slow in some instances, so avoid it when possible.
capnspacehook
force-pushed
the
capnspacehook/avoid-user-current
branch
from
9d9580d
to
a563375
Compare
smallinsky
approved these changes
Apr 12, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
@capnspacehook See the table below for backport results.
|
zmb3
added a commit
that referenced
this pull request
May 9, 2023
In #24156 we removed a lot of unnecessary calls to user.Current, which can take a long time in Active Directory environments. This commit removes a few other uses of user.Current where we were doing a full user lookup only to find the user's home directory, which is usually more readily available via the environment.
zmb3
added a commit
that referenced
this pull request
May 9, 2023
In #24156 we removed a lot of unnecessary calls to user.Current, which can take a long time in Active Directory environments. This commit removes a few other uses of user.Current where we were doing a full user lookup only to find the user's home directory, which is usually more readily available via the environment.
zmb3
added a commit
that referenced
this pull request
May 11, 2023
In #24156 we removed a lot of unnecessary calls to user.Current, which can take a long time in Active Directory environments. This commit removes a few other uses of user.Current where we were doing a full user lookup only to find the user's home directory, which is usually more readily available via the environment.
zmb3
added a commit
that referenced
this pull request
May 11, 2023
In #24156 we removed a lot of unnecessary calls to user.Current, which can take a long time in Active Directory environments. This commit removes a few other uses of user.Current where we were doing a full user lookup only to find the user's home directory, which is usually more readily available via the environment.
zmb3
added a commit
that referenced
this pull request
May 11, 2023
* User os.UserHomeDir where possible In #24156 we removed a lot of unnecessary calls to user.Current, which can take a long time in Active Directory environments. This commit removes a few other uses of user.Current where we were doing a full user lookup only to find the user's home directory, which is usually more readily available via the environment. * Fix tsh profile dir This fixes a bug introduced in #25950
michellescripts
pushed a commit
that referenced
this pull request
May 11, 2023
* User os.UserHomeDir where possible In #24156 we removed a lot of unnecessary calls to user.Current, which can take a long time in Active Directory environments. This commit removes a few other uses of user.Current where we were doing a full user lookup only to find the user's home directory, which is usually more readily available via the environment. * Fix tsh profile dir This fixes a bug introduced in #25950
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling 'user.Current' can be extremely slow in some instances, so avoid it when possible.
Updates https://github.com/gravitational/customer-sensitive-requests/issues/25.