Fix race in TestSSH/ssh_jump_host_access #24195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses the same mechanism as api.client.proxy.clusterName within lib.client.proxyClusterGuesser to prevent races on the cluster name when connecting via ssh.
Using `setupTLSConfigClientCAsForCluster` was overwriting the tls.Config.ClientAuth on each client connection which caused falling back to connecting via ssh.
rosstimothy
force-pushed
the
tross/cluster_guesser_race
branch
from
f63ee89
to
83a968e
Compare
tigrato
approved these changes
Apr 6, 2023
greedy52
approved these changes
Apr 6, 2023
espadolini
approved these changes
Apr 6, 2023
This was referenced Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a data race in the
proxyClusterGuesseras seen inTestSSH/ssh_jump_host_access. The proxy ssh clientproxyClusterGuessernow uses a similar mechanism as the proxy grpc client to protect the inferred cluster name from being updated concurrently.In addition to prevent tests from falling back to using ssh instead of grpc the transport server tls config is no longer using
setupTLSConfigClientCAsForCluster. InsteadGetConfigForClientis set directly and it only updates thetls.Config.ClientCAs.