-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GCP join method #24493
Add GCP join method #24493
Conversation
fd6364a
to
ce571e5
Compare
lib/auth/join.go
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GCP join method needs adding to list at https://github.com/gravitational/teleport/pull/24493/files#diff-125925312bcdffb42ccda3ee44fe8eb2ee10fce23dbdad650a9e00be7521c170R200
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a couple of items in .github/ISSUE_TEMPLATE/testplan.md
for this feature?
This change implements the GCP join method.
cd1f16d
to
7d6177d
Compare
This change implements the GCP join method.
This PR implements the GCP join method (RFD). Part of #22815.