Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tag output from teleport configure as ERROR or WARNING if applies #24670

Merged
merged 2 commits into from
Apr 17, 2023
Merged

Tag output from teleport configure as ERROR or WARNING if applies #24670

merged 2 commits into from
Apr 17, 2023

Conversation

stevenGravy
Copy link
Contributor

@stevenGravy stevenGravy commented Apr 17, 2023 •
edited

Teleport configure outputs messages with no tagging if these are errors or warnings. This updates the messages send to stderr if applies. Also puts colors.

The data directory /var/lib/teleport is not empty and may contain existing cluster state. Running this configuration is likely a mistake. To join a new cluster, specify an alternate --data-dir or clear the /var/lib/teleport directory.
Role db requires further configuration, db_service will be disabled

to
image

Since DB and WindowsDesktop are not applicable provides additional information.

@stevenGravy stevenGravy requested a review from zmb3 April 17, 2023 15:14
zmb3
zmb3 requested changes Apr 17, 2023
View reviewed changes
tool/teleport/common/teleport.go Outdated Show resolved Hide resolved
@stevenGravy stevenGravy added this pull request to the merge queue Apr 17, 2023
Merged via the queue into master with commit 0b8c528 Apr 17, 2023
19 of 20 checks passed
@stevenGravy stevenGravy deleted the stevenGravy/teleportconfiguremessages branch April 17, 2023 17:27
@public-teleport-github-review-bot
Copy link

@stevenGravy See the table below for backport results.

Branch Result
branch/v10 Failed
branch/v11 Create PR
branch/v12 Create PR

This was referenced Apr 17, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AntonAM AntonAM AntonAM approved these changes

@zmb3 zmb3 zmb3 approved these changes

@jimbishopp jimbishopp Awaiting requested review from jimbishopp

@r0mant r0mant Awaiting requested review from r0mant

Assignees
No one assigned
Labels
size/sm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stevenGravy @AntonAM @zmb3