Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Populate the time locked status value when local user locked #25023

Merged
merged 3 commits into from
May 15, 2023
Merged

Populate the time locked status value when local user locked #25023

merged 3 commits into from
May 15, 2023

Conversation

stevenGravy
Copy link
Contributor

@stevenGravy stevenGravy commented Apr 22, 2023 •
edited
Loading

The locked_time field was not set when a user was locked. Now it will be populated when the lock is being set instead of 0001-01-01T00:00:00Z. This is for local user locks after failed login attempts or password resets.

kind: user
metadata:
  id: 1682131098799299000
  name: steven2
spec:
  expires: "0001-01-01T00:00:00Z"
  roles:
  - access
  status:
    is_locked: true
    lock_expires: "2023-04-22T02:58:18.798894Z"
    locked_message: user has exceeded maximum failed login attempts
    locked_time: "2023-04-22T02:38:18.798906Z"
    recovery_attempt_lock_expires: "0001-01-01T00:00:00Z"

@stevenGravy stevenGravy changed the title Populate the time locked status value when user locked Populate the time locked status value when local user locked Apr 22, 2023
zmb3
zmb3 reviewed Apr 24, 2023
View reviewed changes
api/types/user.go Outdated Show resolved Hide resolved
@stevenGravy @zmb3
remove extra line
c21c032 
Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>
rosstimothy
rosstimothy reviewed Apr 25, 2023
View reviewed changes
api/types/user.go Outdated Show resolved Hide resolved
@stevenGravy @rosstimothy
use UTC
30d5674 
Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com>
@stevenGravy
Copy link
Contributor Author

@zmb3 @rosstimothy anything else we need to do here before approving?

@stevenGravy stevenGravy added this pull request to the merge queue May 15, 2023
Merged via the queue into master with commit 8d53253 May 15, 2023
@stevenGravy stevenGravy deleted the stevenGravy/lockedtime branch May 15, 2023 16:35
@public-teleport-github-review-bot
Copy link

@stevenGravy See the table below for backport results.

Branch Result
branch/v11 Create PR
branch/v12 Create PR
branch/v13 Create PR

This was referenced May 15, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmb3 zmb3 zmb3 approved these changes

@rosstimothy rosstimothy rosstimothy approved these changes

Assignees
No one assigned
Labels
backport/branch/v13 size/sm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stevenGravy @zmb3 @rosstimothy