[v12] Record and verify WebAuthn RPIDs #25289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The only conflict was on |
zmb3
approved these changes
Apr 27, 2023
tobiaszheller
approved these changes
Apr 28, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Record and verify the credential RPID in `WebauthnDevice`, so we can detect and warn against accidental RPID changes. RPID changes are not allowed by WebAuthn, so there's little Teleport can do to mitigate them. Users that have only "invalid" WebAuthn devices will get ["invalid credentials"][1] errors on login. While a bit opaque, this is likely to lead to an user reset, which is the correct fix if only a few users are affected. [1]: https://github.com/gravitational/teleport/blob/7a90a0ff9943e4f536736372dbdc90d324f143a2/lib/web/apiserver.go#L2180
codingllama
force-pushed
the
codingllama/backport/25238-v12
branch
from
247f1fd
to
7fe8b0a
Compare
codingllama
force-pushed
the
codingllama/backport/25238-v12
branch
from
7fe8b0a
to
5982def
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Record and verify the credential RPID in
WebauthnDevice, so we can detect and warn against accidental RPID changes.RPID changes are not allowed by WebAuthn, so there's little Teleport can do to mitigate them.
Users that have only "invalid" WebAuthn devices will get "invalid credentials" errors on login. While a bit opaque, this is likely to lead to an user reset, which is the correct fix if only a few users are affected.
Backports #25238 to branch/v12.