Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use xdg-open to open a default browser #2536

Merged
merged 1 commit into from
Jan 31, 2019
Merged

Conversation

alex-kovoy
Copy link
Contributor

As sensible-browser would not always open a default browser, the xdg-open command is going to be used instead. The sensible-browser will be used as a fallback.

Addresses #2454

@UnderGreen
Copy link

👍 from me, sensible-browser is available only on deb-based systems.

@alex-kovoy
Copy link
Contributor Author

After some considerations, I decided to drop sensible-browser as a fallback command. I am not sure how common it is among various distros and since xdg-open has been specifically created to work across different desktop environments and kernels, it would make sense to ask a user to install this package if missing. Besides, some golang internal packages uses 'xdg-open' too.

@alex-kovoy alex-kovoy merged commit c6464a7 into master Jan 31, 2019
@russjones russjones deleted the alexey/defaultbrowser branch February 12, 2019 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants