Add support for automatic database users for Postgres #25614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
database-access
greedy52
reviewed
May 4, 2023
|
@smallinsky @greedy52 I've addressed your feedback folks, mind taking another look? |
greedy52
reviewed
May 11, 2023
greedy52
approved these changes
May 11, 2023
There was a problem hiding this comment.
tested with RDS today and this feature is awesome!
One small nit on a corner case, when admin user is not setup properly, message from tsh is not very obvious what's wrong sometimes:
$ tsh db connect --db-user STeve --db-name test postgres-rds
psql: error: connection to server at "localhost" (::1), port 58348 failed: Connection refused
Is the server running on that host and accepting TCP/IP connections?
connection to server at "localhost" (127.0.0.1), port 58348 failed: FATAL: password authentication failed for user "not-found"
ERROR: exit status 2
Comment on lines
+872
to
+880
| if db.GetAdminUser() != "" && username == "" { | ||
| log.Debugf("Defaulting to Teleport username %q as database username.", tc.Username) | ||
| username = tc.Username | ||
| } |
There was a problem hiding this comment.
a common problem where Teleport Connect code base may require extra changes.
smallinsky
reviewed
May 12, 2023
|
@smallinsky PTAL? |
smallinsky
approved these changes
May 16, 2023
r0mant
force-pushed
the
roman/dbuser
branch
8 times, most recently
from
ed4f7a6
to
9717c48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements RFD 113.
A couple of minor optional things mentioned in the RFD are missing from the implementation (like auditing activate/deactivate queries). I'll add them later while doing more testing during review or as a follow up.