Moved expires to resource metadata for services.Users. #2564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r0mant
approved these changes
Feb 13, 2019
russjones
force-pushed
the
rjones/fix-user-ttl
branch
2 times, most recently
from
14b2458
to
e27f399
Compare
|
I think this problem applies to all users, not just github ones |
klizhentas
requested changes
Feb 14, 2019
|
@klizhentas It does and I fixed it for all external identity providers. I've fixed it for all and covered all with tests. That's what the bulk of the PR was. |
Moved expiry field from spec to metadata for services.Users and updated expiry check to prefer metadata and fallback to spec if not found. Added test coverage.
russjones
force-pushed
the
rjones/fix-user-ttl
branch
from
e27f399
to
a56acc1
Compare
|
k, sorry the PR only showed me two github files, let me re-review |
klizhentas
approved these changes
Feb 18, 2019
|
retest this please |
russjones
force-pushed
the
rjones/fix-user-ttl
branch
from
56e45c4
to
6ef9fbf
Compare
klizhentas
reviewed
Feb 19, 2019
klizhentas
requested changes
Feb 19, 2019
russjones
force-pushed
the
rjones/fix-user-ttl
branch
from
6ef9fbf
to
b9aff5a
Compare
russjones
force-pushed
the
rjones/fix-user-ttl
branch
from
b9aff5a
to
581356a
Compare
klizhentas
approved these changes
Feb 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moved expiry field from spec to metadata for services.Users and updated
expiry check to prefer metadata and fallback to spec if not found. Added
test coverage.