Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the debug command tsh fido2 attobj #25740

Merged
merged 5 commits into from May 9, 2023
Merged

Conversation

codingllama
Copy link
Contributor

Add a helper/debug command to parse attestation objects.

Useful when inspecting MFA devices, otherwise attestation objects are rather opaque to inspect. Works directly with data acquired from tctl get users/foo --with-secrets.

@github-actions github-actions bot added size/md tsh tsh - Teleport's command line tool for logging into nodes running Teleport. labels May 5, 2023
@codingllama
Copy link
Contributor Author

tsh has the other FIDO2 helpers, so it seemed like a not-terrible host for the command. Let me know if you'd rather have it somewhere else, as a standalone utility, or not at all.

The helper comes in handy when trying to compare registered credentials, since we don't record this information "unpacked" in other places.

Copy link
Contributor

@strideynet strideynet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think generally I don't mind tsh being used for debugging tools - we'll need to keep an eye on binary size over time but it seems currently that building out pipelines for distributing other tooling seems quite time-consuming, so for now this seems fine.

Part of me wonders if something like tctl is more a natural home for them for commands that an administrator might use to debug parts of their cluster, I can also envision cases where support teams are working with customer user's that do not have tctl available - and - in many cases, debug commands may need to leverage a connection to a Proxy which tctl does not provide for.

tool/tsh/fido2.go Outdated Show resolved Hide resolved
tool/tsh/fido2.go Outdated Show resolved Hide resolved
tool/tsh/fido2.go Show resolved Hide resolved
@codingllama
Copy link
Contributor Author

PTAL @zmb3 ?

Copy link
Member

@ravicious ravicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested both tsh fido2 commands, they seem to work as advertised.

tool/tsh/fido2.go Outdated Show resolved Hide resolved
@codingllama codingllama added this pull request to the merge queue May 9, 2023
Merged via the queue into master with commit b426612 May 9, 2023
19 checks passed
@codingllama codingllama deleted the codingllama/fido2-attobj branch May 9, 2023 14:11
@public-teleport-github-review-bot

@codingllama See the table below for backport results.

Branch Result
branch/v11 Failed
branch/v12 Create PR
branch/v13 Create PR

codingllama added a commit that referenced this pull request May 9, 2023
* Refactor `tsh fido2` root command

* Add the `tsh fido2 attobj` command

* Use trace.Wrap

* Log swallowed error

* Make argument required
codingllama added a commit that referenced this pull request May 10, 2023
* Add the debug command `tsh fido2 attobj` (#25740)

* Refactor `tsh fido2` root command

* Add the `tsh fido2 attobj` command

* Use trace.Wrap

* Log swallowed error

* Make argument required

* Change imports to duo-labs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/branch/v12 backport/branch/v13 size/md tsh tsh - Teleport's command line tool for logging into nodes running Teleport.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants