Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v13] enable acl in single aws terraform s3 #25854

Merged
merged 4 commits into from May 9, 2023
Merged

[v13] enable acl in single aws terraform s3 #25854

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
573c0c6
update single aws terraform s3
stevenGravy May 8, 2023
8a1f5ca
terraform lint fix
stevenGravy May 8, 2023
b522cfe
Merge branch 'branch/v13' into bot/backport-25847-branch/v13
stevenGravy May 9, 2023
3f9aaf4
Merge branch 'branch/v13' into bot/backport-25847-branch/v13
stevenGravy May 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 11 additions & 2 deletions examples/aws/terraform/starter-cluster/s3.tf
View file
Open in desktop
Expand Up @@ -13,8 +13,17 @@ resource "aws_s3_bucket" "storage" {
}

resource "aws_s3_bucket_acl" "storage" {
bucket = aws_s3_bucket.storage.bucket
acl = "private"
depends_on = [aws_s3_bucket_ownership_controls.storage]
bucket = aws_s3_bucket.storage.bucket
acl = "private"
}

resource "aws_s3_bucket_ownership_controls" "storage" {
bucket = aws_s3_bucket.storage.id

rule {
object_ownership = "BucketOwnerPreferred"
}
}

// For demo purposes, CMK is not needed
Expand Down