Fixes a SharedDirectoryAnnounce incompatibility #25931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SharedDirectoryAnnounce message was changed to remove an unnecessary completionID field, however this change caused an incompatibility between the proxy and previous versions of the wds. This commit reverts that specific change and adds notes to the code explaining the situation. The original change is here: https://github.com/gravitational/teleport/pull/25260/files#diff-98a4bee57beb7f007614e4810d2cf8413bddf48484c8aad6dd0756a218797c36R677-R678
zmb3
reviewed
May 9, 2023
zmb3
approved these changes
May 9, 2023
ravicious
approved these changes
May 10, 2023
public-teleport-github-review-bot
bot
removed the request for review
from kimlisa
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
@ibeckermayer See the table below for backport results.
|
|
Interesting that v12 backport failed, I wonder what's different about v12. |
ibeckermayer
added a commit
that referenced
this pull request
May 11, 2023
* Fixes a SharedDirectoryAnnounce incompatibility The SharedDirectoryAnnounce message was changed to remove an unnecessary completionID field, however this change caused an incompatibility between the proxy and previous versions of the wds. This commit reverts that specific change and adds notes to the code explaining the situation. The original change is here: https://github.com/gravitational/teleport/pull/25260/files#diff-98a4bee57beb7f007614e4810d2cf8413bddf48484c8aad6dd0756a218797c36R677-R678 * changes completionId to discard * adds discard bit to sda.Encode to make fuzz tests happy
This was referenced May 11, 2023
This was referenced May 11, 2023
ibeckermayer
added a commit
that referenced
this pull request
May 11, 2023
* Fixes a SharedDirectoryAnnounce incompatibility The SharedDirectoryAnnounce message was changed to remove an unnecessary completionID field, however this change caused an incompatibility between the proxy and previous versions of the wds. This commit reverts that specific change and adds notes to the code explaining the situation. The original change is here: https://github.com/gravitational/teleport/pull/25260/files#diff-98a4bee57beb7f007614e4810d2cf8413bddf48484c8aad6dd0756a218797c36R677-R678 * changes completionId to discard * adds discard bit to sda.Encode to make fuzz tests happy
ibeckermayer
added a commit
that referenced
this pull request
May 16, 2023
* Fixes a SharedDirectoryAnnounce incompatibility The SharedDirectoryAnnounce message was changed to remove an unnecessary completionID field, however this change caused an incompatibility between the proxy and previous versions of the wds. This commit reverts that specific change and adds notes to the code explaining the situation. The original change is here: https://github.com/gravitational/teleport/pull/25260/files#diff-98a4bee57beb7f007614e4810d2cf8413bddf48484c8aad6dd0756a218797c36R677-R678 * changes completionId to discard * adds discard bit to sda.Encode to make fuzz tests happy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SharedDirectoryAnnounce message was changed to remove an unnecessary completionID field, however this change caused an incompatibility between the proxy and previous versions of the wds. This commit reverts that specific change and adds notes to the code explaining the situation.
The original change is here: https://github.com/gravitational/teleport/pull/25260/files#diff-98a4bee57beb7f007614e4810d2cf8413bddf48484c8aad6dd0756a218797c36R677-R678
closes #25939