Add tsh kubectl support for tracer exporter
#26708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigrato
force-pushed
the
tigrato/tsh-kubectl-tracing
branch
from
51d310c
to
1d9ba30
Compare
github-actions
bot
added
size/sm
tsh
This PR adds support for `--trace` exporter when running `tsh kubectl`. It allows any user to automatically export traces from `tsh`.
tigrato
force-pushed
the
tigrato/tsh-kubectl-tracing
branch
from
1d9ba30
to
301b601
Compare
codingllama
reviewed
May 23, 2023
tool/tsh/kubectl.go
Outdated
| shutdownCtx, cancel := context.WithTimeout(cf.Context, 1*time.Second) | ||
| defer cancel() | ||
| err := provider.Shutdown(shutdownCtx) | ||
| if err != nil && !strings.Contains(err.Error(), context.DeadlineExceeded.Error()) { |
There was a problem hiding this comment.
Could we use errors.Is here instead?
Co-authored-by: Alan Parra <alan.parra@goteleport.com>
Co-authored-by: Alan Parra <alan.parra@goteleport.com>
codingllama
approved these changes
May 23, 2023
gzdunek
approved these changes
May 24, 2023
|
@tigrato may I backport this to v13? I want to backport my other PR but seems to depend on this. This PR doesn't seem to be "risky" either. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for
--traceexporter when runningtsh kubectl.It allows any user to automatically export traces from
tsh.Usage:
tsh --trace --trace-exporter=dir kubectl get pods