Don't load ForwardedPorts from the .tsh/profile #26823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lxea
force-pushed
the
lxea/forward_ports_config
branch
from
664c811
to
a737566
Compare
r0mant
approved these changes
May 30, 2023
There was a problem hiding this comment.
@lxea Have you confirmed that with this fix we're not caching port forwarding configuration in all cases mentioned in the ticket?
#3094 (comment)
#3094 (comment)
#3094 (comment)
If so, lgtm.
public-teleport-github-review-bot
bot
removed the request for review
from kimlisa
Yeah, it should, it just stops |
This was referenced Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was leading to unexpected behavior where tsh was implicitly forwarding ports when running
tsh sshand would make it so a user could not runtsh sshmultiple times simultaneously due to conflicting ports already being open.With this change ports to forward must always be explicitly passed via the
-Lflag.Fix for #3094 and https://github.com/gravitational/customer-sensitive-requests/issues/69.