[v13] Proxy Templates update: cluster switching and tsh ssh parity #26852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use web address when appropriate for a jump hosts Determines whether the jump host provided via `tsh ssh -J` is belongs to the Proxy SSH or Web server to ensure when using jump hosts that connections are established directly on the target cluster. Closes #25178 * Modify tsh tests to capture issues with jump hosts Alters the root and leaf cluster and node names used by tsh tests so that the root cluster is named `root` instead of `localhost` and sets a unique `NodeName` for each cluster instead of reusing `localnode` for both. This was masking problems in jump hosts tests by connecting to the node in the root cluster instead of the leaf cluster. Some additional changes to tsh tests were made as a result of changing the cluster and node names. * fix proxy client tests * update TestList to login once * * Add cluster parsing to proxy templates * Check ProxyTemplates even if -J is not provided * Modify proxy templates logic to work with tsh ssh * Apply suggestions from code review Co-authored-by: Gavin Frazar <gavin.frazar@goteleport.com> --------- Co-authored-by: Tim Ross <tim.ross@goteleport.com> Co-authored-by: Gavin Frazar <gavin.frazar@goteleport.com>
github-actions
bot
added
backport
rfd
r0mant
approved these changes
May 24, 2023
strideynet
approved these changes
May 25, 2023
public-teleport-github-review-bot
bot
removed request for
GavinFrazar and
fspmarshall
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #24586 and #25286 to branch/v13