Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v13] Fetch ClusterAlerts a single time during login #27110

Merged
merged 1 commit into from
May 30, 2023

Conversation

rosstimothy
Copy link
Contributor

Backport #26903 to branch/v13

`onLogin` was inadvertently retrieving ClusterAlerts twice by
explicitly retrieving them and by calling `onStatus`, which also gets
the alerts so they are shown when `tsh status` is invoked. The portion
of `onStatus` which prints the profile has been separated into
`outputProfiles` so that `onLogin` may call that directly instead
of `onStatus`.
@rosstimothy rosstimothy marked this pull request as ready for review May 30, 2023 16:24
@github-actions github-actions bot added backport size/sm tsh tsh - Teleport's command line tool for logging into nodes running Teleport. labels May 30, 2023
@github-actions github-actions bot requested review from Tener and zmb3 May 30, 2023 16:24
@rosstimothy rosstimothy added this pull request to the merge queue May 30, 2023
Merged via the queue into branch/v13 with commit e9b16ef May 30, 2023
24 checks passed
@rosstimothy rosstimothy deleted the bot/backport-26903-branch/v13 branch May 30, 2023 22:43
@r0mant r0mant mentioned this pull request Jul 14, 2023
@fheinecke fheinecke mentioned this pull request Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport size/sm tsh tsh - Teleport's command line tool for logging into nodes running Teleport.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants