[v13] TLS Routing behind ALB: tsh kube subcommands UX (#26305) #27155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* TLS Routing behind ALB: tsh kube subcommands * fix lint and ut * fix ut again * review comment round 1 * fix an issue where local proxy should be not recreated on top a local proxy kubeconfig * move maybeStartKubeLocalProxy to runKubectlReexec, remove os.Setenv * use cf.Stdout * revert kube util.pointer * revert kube util.pointer * Fix fullArgs vs args and remove old KUBECONFIG from env
greedy52
added
kubernetes-access
tsh
tigrato
approved these changes
May 31, 2023
mdwn
approved these changes
May 31, 2023
smallinsky
approved these changes
May 31, 2023
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #26305
only one minor conflict in
go.mod(master has newer packages).