[v13] WebPublicAddr includes user specified port. #27376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The WebPublicAddr function did not include the user specified port for public addresses, which could potentially yield a public address that does not exist. This was impacting the SAML identity provider, which uses this function for determining the public address of the identity provider.
tigrato
approved these changes
Jun 5, 2023
r0mant
approved these changes
Jun 5, 2023
public-teleport-github-review-bot
bot
removed the request for review
from codingllama
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #27269 to branch/v13