[v13] Backport hardened AMI resources #27454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Converts the original JSON Packer template to HCL, preserving the old json version for the legacy AMI builds - Updates and modernises the new HCL template - Creates a slimmed-down `install-hardened.sh` script that avoids installing the monitoring front-end tools, as these are a major source of CIS violations (e.g. pulling in X11) - Splits the exisiting resources in `files` into two classes: - `files` that is common to the old and new AMI, and - `monitor-files` that is only installed on the legacy AMI Note that this patch does not include any high-level tools to drive this packer script from CI/CD. That is coming in a later PR.
* Creates Hardened AMI promotion tool Creates a tool that handles AMI promotion by finding the latest AMI for a given Teleport release and makks it as public. This patch also moves the `update-ami-id` script into its own package directory in the `assets/aws` module, in order to both highlight its use and tidy up the module root. * Apply suggestions from code review Co-authored-by: Noah Stride <noah.stride@goteleport.com> * Update main.go --------- Co-authored-by: Noah Stride <noah.stride@goteleport.com>
github-actions
bot
requested review from
camscale,
fheinecke,
ravicious and
reedloden
zmb3
approved these changes
Jun 6, 2023
r0mant
approved these changes
Jun 6, 2023
There was a problem hiding this comment.
@tcsc Can you please make sure that our Update AMI IDs workflow still works with these changes?
public-teleport-github-review-bot
bot
removed request for
ravicious,
reedloden,
fheinecke and
camscale
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a combination of 2 PRs from
master: