-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v13] Update docker images #27502
Merged
Merged
[v13] Update docker images #27502
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
# This Dockerfile makes the "build box connect" the container used | ||
# to build the Teleport Connect. | ||
# | ||
# This image is base on the node image, which is based on Debian Buster. | ||
# Using it as a image allows us to link agains the same version of | ||
# glibc as Node.js. | ||
# | ||
# Check the README to learn how to safely introduce changes to Dockerfiles. | ||
|
||
## BUILDBOX-CONNECT ################################################################### | ||
|
||
# Pin the tag to Debian Buster to make sure the Glibc compatibility. | ||
ARG NODE_VERSION | ||
FROM node:${NODE_VERSION}-buster AS buildbox | ||
|
||
COPY locale.gen /etc/locale.gen | ||
COPY profile /etc/profile | ||
ENV LANGUAGE="en_US.UTF-8" \ | ||
LANG="en_US.UTF-8" \ | ||
LC_ALL="en_US.UTF-8" \ | ||
LC_CTYPE="en_US.UTF-8" \ | ||
DEBIAN_FRONTEND="noninteractive" | ||
|
||
# Install packages. | ||
RUN apt-get -y update && \ | ||
apt-get install -q -y --no-install-recommends \ | ||
build-essential \ | ||
ca-certificates \ | ||
git \ | ||
libc6-dev \ | ||
libssl-dev \ | ||
locales \ | ||
openssh-client \ | ||
pkg-config \ | ||
python3-pip \ | ||
python3-setuptools \ | ||
python3-wheel \ | ||
# Used during tag builds to build the RPM package of Connect. | ||
rpm \ | ||
&& \ | ||
dpkg-reconfigure locales && \ | ||
apt-get -y clean && \ | ||
rm -rf /var/lib/apt/lists/* | ||
|
||
# Do not create the ci user as we do on other images, as node image | ||
# already has node user with UID:GID 1000:1000 user. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might have missed it in the original discussion, but wouldn't bumping version to 20.04 raise our minimum glibc version requirement?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to backport this as Ubuntu 18.04 is EOL. Bumping the glibc version on the buildbox won't change the glibc version required by Teleport as we're using CentOS 7 for Teleport and the new Connect image for Teleport Connect releases.