Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Web] Add SAML Application flow to Discover #27518

Merged
merged 1 commit into from Jun 16, 2023
Merged

Conversation

rudream
Copy link
Contributor

@rudream rudream commented Jun 7, 2023

Purpose

OSS counterpart to: https://github.com/gravitational/teleport.e/pull/1593

This PR gives the Discover component the ability to accept extra resources that aren't already hardcoded in the component, this makes it possible to pass in the SAML Application resource from enterprise and add it to the Discover page.

This PR also adds the access flags for saml_idp_service_provider resources to the userAcl.

The changes I made to Discover in this PR also resolve #26489

lib/web/ui/usercontext.go Outdated Show resolved Hide resolved
@ryanclark
Copy link
Contributor

Will review tomorrow

Copy link
Contributor

@kimlisa kimlisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much better, thanks for changes 👍

web/packages/teleport/src/useStickyClusterId.ts Outdated Show resolved Hide resolved
@rudream rudream added this pull request to the merge queue Jun 16, 2023
Merged via the queue into master with commit 6be5d88 Jun 16, 2023
32 checks passed
@rudream rudream deleted the yassine/saml-ui-wizard branch June 16, 2023 14:13
@public-teleport-github-review-bot

@rudream See the table below for backport results.

Branch Result
branch/v12 Failed
branch/v13 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enroll new resource page lists "Application" before "Guided" resources
5 participants