New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Web] Add SAML Application flow to Discover #27518
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmb3
approved these changes
Jun 7, 2023
Will review tomorrow |
kimlisa
reviewed
Jun 8, 2023
mdwn
approved these changes
Jun 8, 2023
kimlisa
reviewed
Jun 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
much better, thanks for changes 👍
web/packages/teleport/src/Discover/SelectResource/resources.tsx
Outdated
Show resolved
Hide resolved
web/packages/teleport/src/Discover/SelectResource/resources.tsx
Outdated
Show resolved
Hide resolved
ryanclark
reviewed
Jun 9, 2023
web/packages/teleport/src/Discover/SelectResource/SelectResource.tsx
Outdated
Show resolved
Hide resolved
web/packages/teleport/src/Discover/SelectResource/SelectResource.tsx
Outdated
Show resolved
Hide resolved
kimlisa
approved these changes
Jun 14, 2023
rudream
force-pushed
the
yassine/saml-ui-wizard
branch
from
June 16, 2023 13:28
133fab3
to
e2ae468
Compare
rudream
force-pushed
the
yassine/saml-ui-wizard
branch
from
June 16, 2023 13:33
e2ae468
to
0515de7
Compare
rudream
added a commit
that referenced
this pull request
Jun 16, 2023
rudream
added a commit
that referenced
this pull request
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
OSS counterpart to: https://github.com/gravitational/teleport.e/pull/1593
This PR gives the
Discover
component the ability to accept extra resources that aren't already hardcoded in the component, this makes it possible to pass in the SAML Application resource from enterprise and add it to the Discover page.This PR also adds the access flags for
saml_idp_service_provider
resources to theuserAcl
.The changes I made to Discover in this PR also resolve #26489