Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add node name to the Assist execution result #27635

Merged
merged 4 commits into from
Jun 9, 2023
Merged

Add node name to the Assist execution result #27635

merged 4 commits into from
Jun 9, 2023

Commits on Jun 9, 2023

  1. Add node name to the Assist execution result 

    Currently, only node ID is returned on the command execution result in Assist. For better UX we want to display Node name which id more human friendly rather than a node ID which is a UUID. Adding the value to returned payload sounds cheaper than calling an API to get node names.
    @jakule
    jakule committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    a8ebb32 View commit details
    Browse the repository at this point in the history

  2. Add test

    @jakule
    jakule committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    1bfce2c View commit details
    Browse the repository at this point in the history

  3. Extract commandExecResult struct

    @jakule
    jakule committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    611dfd7 View commit details
    Browse the repository at this point in the history

  4. Fix test after rebase

    @jakule
    jakule committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    4940bda View commit details
    Browse the repository at this point in the history