Abort reverse tunnel connections early if the proxy is already claimed #27683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmb3
approved these changes
Jun 9, 2023
rosstimothy
approved these changes
Jun 9, 2023
public-teleport-github-review-bot
bot
removed the request for review
from marcoandredinis
|
@espadolini See the table below for backport results.
|
This was referenced Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need to complete the SSH handshake if we can tell from the principals of the server (that we read in the host key callback) that the proxy is already claimed.
We still only attempt to claim the proxy after the handshake has completed, which can still fail (two connections at the same time onto the same proxy might both pass the early check), but that's fine as this is only an optimization which saves some time and some CPU.