[v13] Fix an issue ALPN handshake test does not respect "HTTPS_PROXY" #27810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix an issue ALPN handshake test does not respect "HTTPS_PROXY" * address review comment * remove simplehttsproxy * Add context to IsALPNConnUpgradeRequired in ten thousand places * add goc and dial with context
github-actions
bot
added
size/md
tsh
rosstimothy
approved these changes
Jun 13, 2023
smallinsky
approved these changes
Jun 13, 2023
There was a problem hiding this comment.
@greedy52 Seems like CI complains about missing reference to some reversetunnelclient structs:
# github.com/gravitational/teleport/lib/reversetunnelclient
lib/reversetunnelclient/transport.go:47:11: undefined: Resolver
lib/reversetunnelclient/transport.go:110:13: undefined: RemoteAuthServer
public-teleport-github-review-bot
bot
removed the request for review
from webvictim
Thanks! the merge added |
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #27583
minor merge conflict as refactor of
reversetunnelclient(#25447) is not on v13.