feat: adds motd to the ui #27813
Merged
feat: adds motd to the ui #27813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flyinghermit
commented
Jun 13, 2023
kimlisa
reviewed
Jun 13, 2023
kimlisa
reviewed
Jun 13, 2023
zmb3
reviewed
Jun 13, 2023
- update MOTD to Motd - moved motd state to useLogin - added behaviour tests
… address motd warning
Tested in both oss and enterprise. enterprise PR here https://github.com/gravitational/teleport.e/pull/1654
I don't think we would want to preserve acknowledge state (even though UX wise, users may find it annoying). MOTDs are meant to be shown before each login. Admins may also update MOTD frequently. |
kimlisa
approved these changes
Jun 14, 2023
- add unmount test - remove motd title - group states together in useLogin - update arrow func to classic js func
|
Friendly ping for review please @ryanclark @zmb3 |
ryanclark
approved these changes
Jun 15, 2023
This was referenced Jun 16, 2023
flyinghermit
added a commit
that referenced
this pull request
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When MOTD is set, the message is shown before login screen (
tshdoes the same). User's are required to click confirmation button before transitioning to login screen.MOTD in teleport is configurable with
auth_service.message_of_the_dayinteleport.yamlconfig. See docs for setup instruction: https://goteleport.com/docs/server-access/guides/ssh-pam/#display-a-message-of-the-day-motd-with-teleportCloses #13724