fix: Observe accurate backend_read_seconds duration
#27848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @rosstimothy @espadolini, if you do monitor this I would expect a jump once this PR lands. Sorry for making our metrics worse. ;) |
codingllama
commented
Jun 14, 2023
| @@ -124,7 +124,7 @@ func (s *Reporter) GetRange(ctx context.Context, startKey []byte, endKey []byte, | |||
|
|
|||
| start := s.Clock().Now() | |||
| res, err := s.Backend.GetRange(ctx, startKey, endKey, limit) | |||
| batchReadLatencies.WithLabelValues(s.Component).Observe(time.Since(start).Seconds()) | |||
| batchReadLatencies.WithLabelValues(s.Component).Observe(s.Clock().Since(start).Seconds()) | |||
There was a problem hiding this comment.
Using a time.Now/time.Since pair is also fine, but I expect the clock will raise less eyebrows.
codingllama
changed the title
backend_read_seconds duration
espadolini
approved these changes
Jun 14, 2023
|
cc @dilchenko too |
rosstimothy
approved these changes
Jun 14, 2023
public-teleport-github-review-bot
bot
removed the request for review
from tigrato
zmb3
approved these changes
Jun 14, 2023
|
Thanks everyone for the quick reviews. |
|
@codingllama See the table below for backport results.
|
This was referenced Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
backend_read_secondsmetric is not accounting for the read itself, this fixes that. Additionally, we now use the same clock to determine start and end times.